chore: Base Names testnet compatibility #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
|
Deployment failed with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
cpcramer
changed the title
cpcramer
force-pushed
the
paul/fix-basenames
branch
from
41a85fb to
90cac3d
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Zizzamia
reviewed
Aug 2, 2024
| @@ -61,6 +61,7 @@ export type UseGetTokenBalanceResponse = { | |||
| */ | |||
| export type WalletContextType = { | |||
| address?: Address | null; // The Ethereum address to fetch the avatar and name for. | |||
| chain?: Chain; // Optional chain for domain resolution | |||
There was a problem hiding this comment.
So, I think we probably want to start move away from using chain as type. Mostly because we are seeing occasional missmatch with Viem types.
Let's do instead chainId for those things going forward.
There was a problem hiding this comment.
thoughts on merging this and then updating to chainId in the next PR? Because the chainId change will require getName, Name, and useName updates.
There was a problem hiding this comment.
I'll push up the chainId changes and we can split it into two PRs if it's too large
cpcramer
force-pushed
the
paul/fix-basenames
branch
from
a812b14 to
9538ec4
Compare
cpcramer
force-pushed
the
paul/fix-basenames
branch
from
f31f486 to
b0d6c89
Compare
cpcramer
force-pushed
the
paul/fix-basenames
branch
from
b0d6c89 to
ab9ed21
Compare
cpcramer
force-pushed
the
paul/fix-basenames
branch
from
ab9ed21 to
e36b444
Compare
cpcramer
force-pushed
the
paul/fix-basenames
branch
from
e36b444 to
c3d4dab
Compare
cpcramer
force-pushed
the
paul/fix-basenames
branch
from
c3d4dab to
81720f1
Compare
cpcramer
force-pushed
the
paul/fix-basenames
branch
from
81720f1 to
7d0c862
Compare
cpcramer
changed the title
cpcramer
force-pushed
the
paul/fix-basenames
branch
from
7d0c862 to
658d0db
Compare
cpcramer
force-pushed
the
paul/fix-basenames
branch
from
658d0db to
b837f57
Compare
cpcramer
force-pushed
the
paul/fix-basenames
branch
from
b837f57 to
821fd8c
Compare
cpcramer
force-pushed
the
paul/fix-basenames
branch
from
821fd8c to
9a16b9a
Compare
cpcramer
changed the title
Zizzamia
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Base Names was only working on Mainnet. This updates the component to work with EOAs and Smart Wallets on Mainnet and Testnet.
Notes to reviewers
How has it been tested?